feat(@schematics/angular): use signal in app component #29109
Conversation
This updates the generated `AppComponent` to use a signal for the `title` field.
angular-robot
bot
added
detected: feature
| @@ -15,5 +15,5 @@ import { Component } from '@angular/core'; | |||
| styleUrl: './app.component.<%= style %>'<% } %> | |||
| }) | |||
| export class AppComponent { | |||
| title = '<%= name %>'; | |||
| title = signal('<%= name %>'); | |||
There was a problem hiding this comment.
Is it logical for this to be considered a signal, given that it's just a static string? It's feels like this would be a bad usage of signals.
PS: In case we go forward with this we need to update of a couple of other templates.
There was a problem hiding this comment.
If it really is a static string, then using it directly in the template would make more sense than having a dedicated field no? I always saw it as an example of a dynamic string that the code would update.
Let me know if that looks interesting and I'll update the templates I missed 👍
There was a problem hiding this comment.
I am not too strongly about this, but I wonder if it would send the wrong "signal", that anything referenced in the template needs to be a signal. I'll not directly in the template as it's easier to access in tests.
I'll defer to @alxhub. An alternative for correctness maybe I could see this title having the readonly modifier added.
PR Checklist
Please check to confirm your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the new behavior?
Now that signals are recommended, this updates the generated
AppComponentto use a signal for thetitlefield.Does this PR introduce a breaking change?
Other information